Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_handle_uppercase_scheme deprecation #33619

Closed
adisuissa opened this issue Apr 17, 2024 · 0 comments · Fixed by #33727
Closed

envoy_reloadable_features_handle_uppercase_scheme deprecation #33619

adisuissa opened this issue Apr 17, 2024 · 0 comments · Fixed by #33727
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@adisuissa
Copy link
Contributor

Your change commit cd463e5 (http: fixing bugs with mixed case schemes) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@adisuissa adisuissa added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Apr 17, 2024
@alyssawilk alyssawilk mentioned this issue Apr 22, 2024
Merged
alyssawilk added a commit that referenced this issue Apr 23, 2024
@alyssawilk
runtime: deprecate envoy.reloadable_features.handle_uppercase_scheme (#…
351c8e4 
…33727)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
fixes #33619

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
cainelli pushed a commit to cainelli/envoy that referenced this issue Apr 25, 2024
@alyssawilk @cainelli
runtime: deprecate envoy.reloadable_features.handle_uppercase_scheme (e…
46425a8 
…nvoyproxy#33727)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
fixes envoyproxy#33619

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk added a commit to alyssawilk/envoy that referenced this issue Apr 29, 2024
@alyssawilk
runtime: deprecate envoy.reloadable_features.handle_uppercase_scheme (e…
e9c8b67 
…nvoyproxy#33727)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
fixes envoyproxy#33619

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: deprecate envoy.reloadable_features.handle_uppercase_scheme alyssawilk/envoy
2 participants
@adisuissa @alyssawilk