Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why add user home in devcontainer #33758

Closed
ShenFeng312 opened this issue Apr 24, 2024 · 6 comments
Closed

Why add user home in devcontainer #33758

ShenFeng312 opened this issue Apr 24, 2024 · 6 comments
Labels
area/dev question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@ShenFeng312
Copy link

image

@ShenFeng312 ShenFeng312 added the triage Issue requires triage label Apr 24, 2024
@wbpcode wbpcode added question Questions that are neither investigations, bugs, nor enhancements area/dev and removed triage Issue requires triage labels Apr 24, 2024
@wbpcode
Copy link
Member

wbpcode commented Apr 24, 2024

cc @lizan

@phlax
Copy link
Member

phlax commented Apr 24, 2024

@ShenFeng312 im guessing the idea is for accessing any user configs, but my feeling is that its probably not necessary, at least as the default.

relatedly i wonder what the utiltity of the CAPs above are - they essentially allow the container to root the host (altho i guess mitigated by running as non-root).

im perhaps not the best person to review as i dont use vscode myself - but would be happy to review any cleanups to this setup - as far as i can

@ShenFeng312
Copy link
Author

@phlax
Can you tell me what tools you use for development? I'm not particularly keen on using VSCode either. However, it seems like the official documentation mainly covers VSCode-related topics. I'm doing development on Ubuntu desktop. Also, the files generated by Envoy compilation are too large. The envoy-build volume is occupying around 20GB of disk space (possibly more; I deleted the previous container due to issues).

@phlax
Copy link
Member

phlax commented Apr 25, 2024

Can you tell me what tools you use for development?

mostly emacs, but im not going to recommend doing that unless you are already an emacs user

... the files generated by Envoy compilation are too large.

i think that is pretty unavoidable, especially if you want a debug build

The envoy-build volume is occupying around 20GB of disk space ...

the default/recommended way of running is with ./ci/run_envoy_docker.sh this mounts a temp volume from fs (default is /tmp/envoy-docker-build) - i export ENVOY_DOCKER_BUILD_DIR=/home/phlax/bazel_cache before using this way to ensure i reuse cache and dont fill my /tmp directory

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 25, 2024
Copy link

github-actions bot commented Jun 1, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants