Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_load_cc_rules_from_bzl will break Envoy in Bazel 4.0 #9488

Closed
bazel-flag-bot opened this issue Dec 26, 2019 · 0 comments
Closed

Flag --incompatible_load_cc_rules_from_bzl will break Envoy in Bazel 4.0 #9488

bazel-flag-bot opened this issue Dec 26, 2019 · 0 comments
Assignees
@lizan
Labels
area/build no stalebot Disables stalebot from closing an issue

Comments

@bazel-flag-bot
Copy link

Incompatible flag --incompatible_load_cc_rules_from_bzl will be enabled by default in Bazel 3.0, thus breaking Envoy.

The flag is documented here: bazelbuild/bazel#8743

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.

If you don't want to receive any future issues for Envoy or if you have any questions,
please file an issue in https://github.com/bazelbuild/continuous-integration

Important: Please do NOT modify the issue title since that might break our tools.
@mattklein123 mattklein123 added area/build no stalebot Disables stalebot from closing an issue labels Dec 26, 2019
@mattklein123 mattklein123 added this to the 1.14.0 milestone Dec 29, 2019
@mattklein123 mattklein123 modified the milestones: 1.14.0, 1.15.0 Mar 10, 2020
This was referenced Mar 31, 2020
Merged
Closed
lizan added a commit to bufbuild/protoc-gen-validate that referenced this issue Apr 1, 2020
@lizan
build: make it build with bazelisk --strict (#327)
0f2bc6c 
For envoyproxy/envoy#9490 envoyproxy/envoy#9489 envoyproxy/envoy#9488

Signed-off-by: Lizan Zhou lizan@tetrate.io
@lizan lizan changed the title Flag --incompatible_load_cc_rules_from_bzl will break Envoy in Bazel 3.0 Flag --incompatible_load_cc_rules_from_bzl will break Envoy in Bazel 4.0 Apr 21, 2020
@lizan lizan mentioned this issue Apr 21, 2020
Closed
@lizan lizan mentioned this issue Jun 2, 2020
Merged
lizan added a commit that referenced this issue Jun 3, 2020
@lizan
build: use rules_cc and use buildifier -lint to enforce it (#11399)
67649af 
Commit Message:
Partially address #9488. Resurrected #10597.

Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
auni53 pushed a commit to auni53/envoy that referenced this issue Jun 4, 2020
@lizan @auni53
build: use rules_cc and use buildifier -lint to enforce it (envoyprox…
2688edc 
…y#11399)

Commit Message:
Partially address envoyproxy#9488. Resurrected envoyproxy#10597.

Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Auni Ahsan <auni@google.com>
@mattklein123 mattklein123 removed this from the 1.15.0 milestone Jun 17, 2020
yashwant121 pushed a commit to yashwant121/envoy that referenced this issue Jul 24, 2020
@lizan @yashwant121
build: use rules_cc and use buildifier -lint to enforce it (envoyprox…
f7c44db 
…y#11399)

Commit Message:
Partially address envoyproxy#9488. Resurrected envoyproxy#10597.

Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizan lizan

Labels
area/build no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lizan @mattklein123 @bazel-flag-bot