Move Tracers to top-level dependency position. #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to a new static registration process optional tracers like Lightstep and Zipkin can be added as top level dependencies of the site specific main build. This change cleans up the remaining items required to make a site specific main that does not link in Lightstep and Zipkin libraries.
mattklein123
approved these changes
Jun 8, 2017
|
LGTM |
htuch
approved these changes
Jun 8, 2017
|
|
||
| envoy_cc_library( | ||
| name = "lightstep_tracer_lib", | ||
| srcs = [ |
There was a problem hiding this comment.
Nit: Very slight preference for srcs = ["foobar.cc"], style when there is only one item in the list.
There was a problem hiding this comment.
If it's OK with you I'd rather not wait for another 40 minute travis build for this. I'll do single line unless buildifier overrules in the future.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a new static registration process optional tracers like
Lightstep and Zipkin can be added as top level dependencies of the site
specific main build. This change cleans up the remaining items required
to make a site specific main that does not link in Lightstep and Zipkin
libraries.