tests: Reference sh test script to be run with ./

[sunjayBhatia]

Commit Message: Enable sh tests to run on Windows by referencing scripts with ./
Additional Description:

• without it, we get <testscript>: command not found
• once bazel 3.1.0 is enabled for Envoy (contains the fix for this issue: Windows sh_test invocation and test environment different from Linux causing unexpected results bazelbuild/bazel#10959) and this change is merged, we will be able to run envoy_sh_test based tests

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

[zuercher]

If I understand correctly, this won't be necessary after bazel 3.1.0. If I've got that right, we should a todo here (in our standard style with a github username) to revert this once that's in place.

[sunjayBhatia]

@zuercher actually, this will be necessary after bazel 3.1.0, currently with bazel 3.0.0 and below the sh_test_wrapper.sh does not have the correct execution environment/runfiles setup/symlinks so the test file the envoy_sh_test rule sets up cannot find the test script to invoke at all (even with ./), with bazel 3.1.0 and above, the runfiles are set up correctly for the sh_test rule, but running the sh_test_wrapper.sh script as-is causes the command not found error, adding ./ fixes that for bazel 3.1.0

I can re-clarify in the issue description if needed to make that clearer

[sunjayBhatia]

this is a minimal example that demonstrates the issue (linked in the bazel issue above): https://github.com/greenhouse-org/bazel-issue-repro/blob/c7ebe740e6cf12b58c7c7e156d9f5d2670329aad/sh_test_symlinks/README.md

[sunjayBhatia]

interestingly, on Linux I just noticed . is added to the PATH and that is not the case when bash is invoked on Windows, so that might be something to look into as well

[sunjayBhatia]

interestingly, on Linux I just noticed . is added to the PATH and that is not the case when bash is invoked on Windows, so that might be something to look into as well

this general issue could be solved by adding . to the path in the wrapper script (to ensure the execution environment is correct regardless of any PATH variables set by the shell) or the ./ solution

[sunjayBhatia]

/retest

[repokitteh-read-only]

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #10977 (comment) was created by @sunjayBhatia.

see: more, trace.