grpc/transcoding: add support for fragmented httpBody #11060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng httpBody Signed-off-by: Konstantin Belyalov <arsenicus@mail.ru>
Signed-off-by: Konstantin Belyalov <arsenicus@mail.ru>
|
@npuichigo FYI |
lizan
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description: As mentioned in #10673 when transcoding of
httpBodyin streaming mode and grpc frame gets fragmented (e.g. large enough) - http headerContent-Typemay not be set to correct value fromcontent-typeofhttpBody.Risk Level: low
Testing: new unit/integration test
Docs Changes: not changed bcz of this feature was introduced in the same release
Release Notes: not added bcz of this feature was introduced in the same release