async_client: minor refactor to response body handling #13339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
dio,
lizan and
mattklein123
as code owners
dio
reviewed
Sep 30, 2020
| @@ -258,8 +258,7 @@ void RawHttpClientImpl::check(RequestCallbacks& callbacks, Event::Dispatcher& di | |||
| Http::RequestMessagePtr message = | |||
| std::make_unique<Envoy::Http::RequestMessageImpl>(std::move(headers)); | |||
| if (request_length > 0) { | |||
| message->body() = | |||
| std::make_unique<Buffer::OwnedImpl>(request.attributes().request().http().body()); | |||
| message->body().add(request.attributes().request().http().body()); | |||
mattklein123
approved these changes
Oct 1, 2020
| @@ -44,15 +44,15 @@ void RemoteDataFetcher::onSuccess(const Http::AsyncClient::Request&, | |||
| const uint64_t status_code = Http::Utility::getResponseStatus(response->headers()); | |||
| if (status_code == enumToInt(Http::Code::OK)) { | |||
| ENVOY_LOG(debug, "fetch remote data [uri = {}]: success", uri_.uri()); | |||
| if (response->body()) { | |||
| if (response->body().length() > 0) { | |||
There was a problem hiding this comment.
Might be worth it to add an empty() method to Buffer at some point.
There was a problem hiding this comment.
haha yeah, I'm so used to getting reminded to use empty() over length() > 0 I started with that and was surprised when it didn't compile :-P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #13328, always creating a body buffer to avoid the pattern of null pointer derefs.
Risk Level: Medium
Testing: unit tests pass
Docs Changes: n/a
Release Notes: yes