listener: respect address.pipe.mode (it didn't work) #13493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems listener[].address.pipe.mode configuration wasn't working under v3 api. Fixes envoyproxy#11809 Signed-off-by: Sorah Fukumori <her@sorah.jp>
|
I thought that some commit broke this feature, but I couldn't confirm the |
|
Trying to add an integration test as it has never worked properly. (PR #8423 was changing |
commit 750431a added the feature w/ unit tests but wasn't working properly. Adding integration test to make it sure. Signed-off-by: Sorah Fukumori <her@sorah.jp>
lizan
reviewed
Oct 11, 2020
fix miss copy and paste Signed-off-by: Sorah Fukumori <her@sorah.jp>
Signed-off-by: Sorah Fukumori <her@sorah.jp>
Signed-off-by: Sorah Fukumori <her@sorah.jp>
the unit test, PipeInstanceTest/BasicPermission is also skipped on win32 Signed-off-by: Sorah Fukumori <her@sorah.jp>
stat(2) fails with ENOENT against Windows dialect AF_UNIX socket files, while chmod(2) succeeds. Signed-off-by: Sorah Fukumori <her@sorah.jp>
Signed-off-by: Sorah Fukumori <her@sorah.jp>
Signed-off-by: Sorah Fukumori <her@sorah.jp>
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
|
CIs passed. |
sorah
changed the title
lizan
approved these changes
Oct 12, 2020
Signed-off-by: Sorah Fukumori <her@sorah.jp>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 14, 2020
* master: (22 commits) http: using CONNECT_ERROR for HTTP/2 (envoyproxy#13519) listener: respect address.pipe.mode (it didn't work) (envoyproxy#13493) examples: Fix more deprecations/warnings in configs (envoyproxy#13529) overload: tcp connection refusal overload action (envoyproxy#13311) tcp: towards pluggable upstreams (envoyproxy#13331) conn_pool: fixing comments (envoyproxy#13520) Prevent SEGFAULT when disabling listener (envoyproxy#13515) Convert overload manager config literals to YAML (envoyproxy#13518) Fix runtime feature variable name (envoyproxy#13533) dependencies: refactor repository location schema utils, cleanups. (envoyproxy#13452) router: fix an invalid ASSERT when encoding metadata frames in the router. (envoyproxy#13511) http2: Proactively disconnect connections flooded when resetting stream (envoyproxy#13482) ci use azp to sync filter example (envoyproxy#13501) mongo_proxy: support configurable command list for metrics (envoyproxy#13494) http local rate limit: note token bucket is shared (envoyproxy#13525) wasm/extensions: Wasm extension policy. (envoyproxy#13526) http: removing envoy.reloadable_features.http1_flood_protection (envoyproxy#13508) build: update ppc64le CI build status shield (envoyproxy#13521) dependencies: enforce dependency shepherd sign-off via RepoKitteh. (envoyproxy#13522) Add no_traffic_healthy_interval (envoyproxy#13336) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listener[].address.pipe.modeconfiguration wasn't working since it has been landed, as it was ignored during resolution from config object to Address instance.This patch fixes the following configuration working as expected.
Commit Message: listener: respect address.pipe.mode (it didn't work)
Risk Level: Low
Testing: added integration test
Docs Changes: N/A
Release Notes: N/A
Fixes: #11809