Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove/make generic Lyft references #13559

Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 14, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs: Remove/make generic Lyft references
Additional Description:

see #13490 (comment)

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@phlax phlax force-pushed the docs-remove-old-lyft-references branch from 4cc717b to f53220d Compare October 14, 2020 08:47
@phlax phlax changed the title docs: Remove/make generic lyft references docs: Remove/make generic Lyft references Oct 14, 2020
@phlax phlax force-pushed the docs-remove-old-lyft-references branch from f53220d to c6926b6 Compare October 14, 2020 09:11
@phlax
Copy link
Member Author

phlax commented Oct 14, 2020

@mattklein123 this removes the Lyft references from any prose in the docs.

There are some remaining eg example urls/cert that still use lyft

@phlax
Copy link
Member Author

phlax commented Oct 14, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13559 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the docs-remove-old-lyft-references branch from c6926b6 to c71b625 Compare October 14, 2020 12:56
@phlax
Copy link
Member Author

phlax commented Oct 14, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13559 (comment) was created by @phlax.

see: more, trace.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@mattklein123 mattklein123 merged commit 5607d1b into envoyproxy:master Oct 14, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 15, 2020
* master:
  ci: use multiple stage (envoyproxy#13557)
  tls: update BoringSSL to 2192bbc8 (4240). (envoyproxy#13567)
  fix macos v8 build (envoyproxy#13572)
  Fixed Health Check Fuzz corpus syntax (envoyproxy#13576)
  ci: Remove shellcheck diff (envoyproxy#13560)
  ci: Increate brew retry interval (envoyproxy#13565)
  dependencies: fix some of the fallout from Wasm merge. (envoyproxy#13569)
  hds: add support for delta updates in specifier (envoyproxy#13067)
  ci: workaround for actions/runner-images#1811 (envoyproxy#13577)
  ratelimit: be able to disable x-envoy-ratelimited response header sent (envoyproxy#13270)
  Update opencensus library (envoyproxy#13549)
  ci: use azp for api and go-control-plane sync (envoyproxy#13550)
  docs: Remove/make generic lyft references in docs (envoyproxy#13559)
  check_format: adding 2 more release note checks (envoyproxy#13444)
  [Wasm] Add cluster metadata fallback and upstream host metadata (envoyproxy#13477)
  [fuzz] Added validation for secrets (envoyproxy#13543)
  Add Platform Specific Feature guidance to PR template (envoyproxy#13547)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants