Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows CI] Fix issue with Slack message for flaky tests #14252

Merged
merged 5 commits into from Dec 3, 2020

Conversation

davinci26
Copy link
Member

Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
See recent CI build runs and slackapi/python-slack-sdk#334 (comment)

Risk Level: Low
Testing: CI

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@davinci26
Copy link
Member Author

cc @envoyproxy/windows-dev creating as Draft and I will push a few empty commits to hopefully get some flakes and see the message in the chat.

@sunjayBhatia
Copy link
Member

cc @envoyproxy/windows-dev creating as Draft and I will push a few empty commits to hopefully get some flakes and see the message in the chat.

you might have to turn off caching here otherwise all the tests will always pass in this PR and we wont see flakes

Sotiris Nanopoulos added 3 commits December 2, 2020 17:11
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@davinci26 davinci26 marked this pull request as ready for review December 3, 2020 16:55
@davinci26
Copy link
Member Author

@lizan @sunjayBhatia you can review now.

@sunjayBhatia
Copy link
Member

@davinci26 maybe just add a comment in the script describing why this is necessary? otherwise LGTM, seems to work 👍

@sunjayBhatia
Copy link
Member

@davinci26 maybe just add a comment in the script describing why this is necessary? otherwise LGTM, seems to work 👍

for posterity, there was a flaky test here: https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/59567/logs/158

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@davinci26
Copy link
Member Author

davinci26 commented Dec 3, 2020

@davinci26 maybe just add a comment in the script describing why this is necessary?

Added a small comment

@mattklein123 mattklein123 self-assigned this Dec 3, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 73c2d57 into envoyproxy:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants