-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows CI] Fix issue with Slack message for flaky tests #14252
[Windows CI] Fix issue with Slack message for flaky tests #14252
Conversation
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
cc @envoyproxy/windows-dev creating as Draft and I will push a few empty commits to hopefully get some flakes and see the message in the chat. |
you might have to turn off caching here otherwise all the tests will always pass in this PR and we wont see flakes |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@lizan @sunjayBhatia you can review now. |
@davinci26 maybe just add a comment in the script describing why this is necessary? otherwise LGTM, seems to work 👍 |
for posterity, there was a flaky test here: https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/59567/logs/158 |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Added a small comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
See recent CI build runs and slackapi/python-slack-sdk#334 (comment)
Risk Level: Low
Testing: CI