Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatter: add a formatter that returns a google::protobuf::Struct rather than a string #14258

Merged
merged 5 commits into from
Dec 16, 2020
Merged

formatter: add a formatter that returns a google::protobuf::Struct rather than a string #14258

merged 5 commits into from
Dec 16, 2020

Commits on Dec 10, 2020

  1. Split the JSON (string) formatter to a Struct (proto) formatter and a… 

    … wrapper that generates a string

Signed-off-by: Itamar Kaminski <itamark@google.com>
    @itamarkam
    itamarkam committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6fe09ac View commit details
    Browse the repository at this point in the history

  2. Tests for StructFormatter 

    Signed-off-by: Itamar Kaminski <itamark@google.com>

Delete some leftovers

Signed-off-by: Itamar Kaminski <itamark@google.com>

Delete some leftovers

Signed-off-by: Itamar Kaminski <itamark@google.com>

clang-format

Signed-off-by: Itamar Kaminski <itamark@google.com>

Revert "clang-format"

This reverts commit 4576bc86fdb8baa2f161bde2dbdd7871169f725f.

Signed-off-by: Itamar Kaminski <itamark@google.com>

Fix error message formatting test

Fix clang-tidy

Signed-off-by: Itamar Kaminski <itamark@google.com>

Fix clang tidy again

Signed-off-by: Itamar Kaminski <itamark@google.com>
    @itamarkam
    itamarkam committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    7055084 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Review fixes 

    Signed-off-by: Itamar Kaminski <itamark@google.com>
    @itamarkam
    itamarkam committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    e2675c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Fix error message typo 

    Signed-off-by: Itamar Kaminski <itamark@google.com>
    @itamarkam
    itamarkam committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    67bc523 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Merge branch 'master' into master

    @itamarkam
    itamarkam committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    ca6345c View commit details
    Browse the repository at this point in the history