api: add internal listener #15376
Merged
api: add internal listener #15376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
The WIP implementation can be found in lambdai#11 |
htuch
reviewed
Mar 9, 2021
htuch
reviewed
Mar 9, 2021
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
requested changes
Mar 9, 2021
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
/retest |
|
Retrying Azure Pipelines: |
kyessenov
reviewed
Mar 10, 2021
| // allowed because both cluster connection and listener connection must be owned by the same dispatcher. | ||
| // * :ref:`tcp_backlog_size <envoy_api_field_config.listener.v3.Listener.tcp_backlog_size>` | ||
| // * :ref:`freebind <envoy_api_field_config.listener.v3.Listener.freebind>` | ||
| // * :ref:`transparent <envoy_api_field_config.listener.v3.Listener.transparent>` |
There was a problem hiding this comment.
Do internal listeners support passing additional metadata from source? This would be interesting to be able to propagate filter metadata or filter state without the wire encoding.
There was a problem hiding this comment.
That's a good question.
Let me complete the doc and share it with you. It's easy to implement but it's hard to utilize such ability. The api will be weird if the proportion only work with internal connection
auni53
pushed a commit
to auni53/envoy
that referenced
this pull request
Mar 19, 2021
Signed-off-by: Yuchen Dai <silentdai@gmail.com> Signed-off-by: Auni Ahsan <auni@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Add listener type
internal listenerSigned-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Discussed #11725
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]