deps: update protobuf to 3.16.0 #16390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
benjaminp
force-pushed
the
up-protobuf
branch
3 times, most recently
from
480413a
to
7de5df8
Compare
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Outdated
Show resolved
Hide resolved
benjaminp
force-pushed
the
up-protobuf
branch
2 times, most recently
from
9f8c771
to
885550e
Compare
grpc-httpjson-transcoding must also be updated to handle incompatible changes in the protobuf Status stubs. Signed-off-by: Benjamin Peterson <benjamin@dropbox.com>
Signed-off-by: Benjamin Peterson <benjamin@dropbox.com>
repokitteh-read-only
bot
added
the
deps
|
/retest |
|
Retrying Azure Pipelines: |
|
@envoyproxy/dependency-shepherds could use your review. |
|
/retest |
|
Retrying Azure Pipelines: |
moderation
reviewed
May 14, 2021
Comment on lines
+601
to
+606
| version = "3.16.0", | ||
| sha256 = "d7371dc2d46fddac1af8cb27c0394554b068768fc79ecaf5be1a1863e8ff3392", | ||
| strip_prefix = "protobuf-{version}", | ||
| urls = ["https://github.com/protocolbuffers/protobuf/releases/download/v{version}/protobuf-all-{version}.tar.gz"], | ||
| use_category = ["dataplane_core", "controlplane"], | ||
| release_date = "2020-11-13", | ||
| release_date = "2021-05-06", |
There was a problem hiding this comment.
3.17.0 was released 2 days ago - https://github.com/protocolbuffers/protobuf/releases/tag/v3.17.0. Any interest in jumping to that version or do in a follow up?
There was a problem hiding this comment.
Sure, I can bump it now.
There was a problem hiding this comment.
And it turns out 3.17.0 has a regression, so that won't work. protocolbuffers/protobuf#8611
|
/lgtm deps |
repokitteh-read-only
bot
added
deps
benjaminp
force-pushed
the
up-protobuf
branch
2 times, most recently
from
28461fc
to
d3b561f
Compare
benjaminp
changed the title
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
repokitteh-read-only
bot
added
the
deps
benjaminp
changed the title
repokitteh-read-only
bot
removed
the
deps
ntgsx92
pushed a commit
to ntgsx92/envoy
that referenced
this pull request
May 18, 2021
Signed-off-by: Benjamin Peterson <benjamin@dropbox.com> Signed-off-by: Sixiang Gu <sgu@twitter.com>
musaprg
pushed a commit
to musaprg/envoy
that referenced
this pull request
Jun 14, 2021
Signed-off-by: Benjamin Peterson <benjamin@dropbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]