dfp: adding a pause test #17580
Closed
dfp: adding a pause test #17580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
/wait |
|
/wait for tsan debug |
PiotrSikora
suggested changes
Aug 5, 2021
| ASSERT_TRUE(fake_upstreams_[0]->waitForHttpConnection(*dispatcher_, fake_upstream_connection_)); | ||
| ASSERT_TRUE(fake_upstream_connection_->waitForNewStream(*dispatcher_, upstream_request_)); | ||
| ASSERT_FALSE(upstream_request_->waitForData(*dispatcher_, 1, std::chrono::milliseconds(100))); | ||
| } |
There was a problem hiding this comment.
This test isn't representative, because DNS is immediately resolved, and dynamic-forward-proxy resumes before processing body, so buffer-body-filter never had a chance to pause it:
decode headers called: filter=0x15b9fdbcae00 status=0 // buffer headers (continue)
decode headers called: filter=0x15b9fdbf1f10 status=4 // dfp headers (pause)
continuing filter chain: filter=0x15b9fdbf1f10 // dfp headers (continue)
decode headers called: filter=0x15b9fe1019d0 status=1 // router headers
decode data called: filter=0x15b9fdbcae00 status=1 // buffer body (pause)
Compare with the reported issue (#17514 (comment)):
decode headers called: filter=0x444afcea08c0 status=0 // wasm headers (continue)
decode headers called: filter=0x444afcea09a0 status=4 // dfp headers (pause)
decode data called: filter=0x444afcea08c0 status=1 // wasm body (pause)
decode data called: filter=0x444afcea08c0 status=1 // wasm body (pause)
continuing filter chain: filter=0x444afcea09a0 // dfp headers (continue)
decode headers called: filter=0x444afcea0a10 status=1 // router headers
decode data called: filter=0x444afcea09a0 status=0 // dfp body (continue)
decode data called: filter=0x444afcea0a10 status=3 // router body
There was a problem hiding this comment.
It looks like we may need a custom filter to test this case.
|
/wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: n/a (test only)
Testing: yes
Docs Changes: n/a
Release Notes: n/a
Part of #17514