New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factories: renaming to mainThreadDispatcher #18122
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
826a308
to
68b2c3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Wasm part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this turned out to be much larger than I was expecting. I hope you had good tools to help you do all these changes.
it's going to take me a bit to get through this, as I have some perf deadlines coming up.
Yeah it's a doozy. I'm glad you were Ok with me splitting it out :-P |
- updated bazel/repositories.bzl - .bazelrc already in sync - added `CONTRIB_EXTENSION_PACKAGE_VISIBILITY = ["//:contrib_library"]` to https://github.com/envoyproxy/nighthawk/blob/main/extensions_build_config.bzl to fix the failure from running `ci/do_ci.sh build` which is caused by envoyproxy/envoy#18131 - changed `api_.randomGenerator()` to `context_.api().randomGenerator()` in `ClusterManagerFactory` which is caused by envoyproxy/envoy#18122 Signed-off-by: qqustc@gmail.com <qqin@google.com>
Also using the new factory API in one more place which I can back out if you prefer.
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a