Dns: respecting DNS TTL #18408
Merged
Dns: respecting DNS TTL #18408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htuch
reviewed
Oct 6, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
merged up. PTAL |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
snowp
suggested changes
Oct 12, 2021
| @@ -10,6 +10,7 @@ Minor Behavior Changes | |||
| *Changes that may cause incompatibilities for some users, but should not for most* | |||
|
|
|||
| * config: the log message for "gRPC config stream closed" now uses the most recent error message, and reports seconds instead of milliseconds for how long the most recent status has been received. | |||
| * dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>` This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false. | |||
There was a problem hiding this comment.
two spaces between resolved hosts
envoy/common/backoff_strategy.h
Outdated
| /** | ||
| * Resets the interval with a (potentially) new starting point. | ||
| */ | ||
| virtual void reset(uint64_t base) PURE; |
There was a problem hiding this comment.
base -> base_interval?
Also add @param comment?
Comment on lines
119
to
120
| const MonotonicTime stale_time = stale_at_time_; | ||
| return time_source_.monotonicTime() > stale_time; |
There was a problem hiding this comment.
How come we don't just compare with stale_at_time_ directly?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
@snowp any other requests? |
|
cc @junr03 @buildbreaker if you see any changes here we can flip the flag back and let me know ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the DNS cache to respect the advertised TTL, modulo a floor of 5s.
That part of the change is runtime guard. The part which is not, is that the backoff is done on a per-host basis not a global basis, so if one endpoint fails to resolve, it won't result in others backing off, and if one succeeds it won't result in changing backoff for failed hosts.
Risk Level: Medium
Testing: new unit tests
Docs Changes: inline
Release Notes: inline
Optional Runtime guard: envoy.reloadable_features.use_dns_ttl