[Backport 1.21] TLS: Allow specification of both typed and non-typed san matchers in config (20529) #21170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…san matchers in config (20529) Signed-off-by: Pradeep Rao <pcrao@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/retest |
|
Retrying Azure Pipelines: |
|
/assign @ggreenway |
ggreenway
previously approved these changes
May 9, 2022
|
/assign @adisuissa |
|
CI is failing |
Signed-off-by: Pradeep Rao <pcrao@google.com>
Can't reproduce the build failure locally. Doing a merge to kick off tests again. |
…1_21 Signed-off-by: Pradeep Rao <pcrao@google.com>
adisuissa
requested changes
May 13, 2022
Comment on lines
12
to
13
| * cryptomb: remove RSA PKCS1 v1.5 padding support. | ||
| * perf: ssl contexts are now tracked without scan based garbage collection and greatly improved the performance on secret update. |
There was a problem hiding this comment.
These changes don't seem related to the current backport PR.
There was a problem hiding this comment.
Aah, this happened because of this: https://github.com/envoyproxy/envoy/pull/21226/files
Fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pradeep Rao pcrao@google.com
Commit Message:
Additional Description:
Backport #20529 to 1.21
Risk Level: Low
Testing: Modified test.
Docs Changes:
Release Notes:
Platform Specific Features: