config: add and populate metadata accessor in ClusterInfo #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <mattrice@google.com>
mrice32
force-pushed
the
cluster_metadata
branch
from
2820f54
to
f223c07
Compare
| @@ -706,6 +707,34 @@ TEST(PrioritySet, Extend) { | |||
| } | |||
| } | |||
|
|
|||
| // Resolve zero hosts, while using health checking. | |||
There was a problem hiding this comment.
nit: this is not really what this test is about. :)
| )EOF"; | ||
|
|
||
| auto cluster_config = parseClusterFromV2Yaml(yaml); | ||
| Config::Metadata::mutableMetadataValue(*cluster_config.mutable_metadata(), "com.bar.foo", "baz") |
There was a problem hiding this comment.
nit: is it possible to add this to the YAML instead for clarity?
There was a problem hiding this comment.
Yep, I only did it this way because the yaml for metadata is a little obfuscated/ugly:
...
metadata: { filter_metadata: { com.bar.foo: { baz: test_value } } }
...
Totally cool doing it that way as long as that seems clearer.
There was a problem hiding this comment.
It would be clearer to me and I think more instructive for how static config would be written, but I'm fine either way.
There was a problem hiding this comment.
Gotcha. That's a good point - I didn't see another example of metadata in yaml or json.
Signed-off-by: Matt Rice <mattrice@google.com>
Signed-off-by: Matt Rice <mattrice@google.com>
htuch
previously approved these changes
Jan 11, 2018
include/envoy/upstream/upstream.h
Outdated
| @@ -428,6 +430,11 @@ class ClusterInfo { | |||
| * @return the configuration for load balancer subsets. | |||
| */ | |||
| virtual const LoadBalancerSubsetInfo& lbSubsetInfo() const PURE; | |||
|
|
|||
| /** | |||
| * @return the configuration metadata for this cluster. | |||
There was a problem hiding this comment.
Nit: @return const envoy::api::v2::Metadata& the configuration...
Signed-off-by: Matt Rice <mattrice@google.com>
mattklein123
approved these changes
Jan 11, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* Fix postsubmit. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * review: use $(bazel info output_path). Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
We may be interested in experimenting with network monitoring & interface switching completely disabled to assess the impact of this feature. Disabling network switching is not something we recommend generally. Risk Level: Low, adds the ability to disable network switching on an opt-in basis Testing: Updated unit tests Docs Changes: Added Release Notes: Added Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
We may be interested in experimenting with network monitoring & interface switching completely disabled to assess the impact of this feature. Disabling network switching is not something we recommend generally. Risk Level: Low, adds the ability to disable network switching on an opt-in basis Testing: Updated unit tests Docs Changes: Added Release Notes: Added Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Made the cluster metadata field visible in ClusterInfo for access by filters and access logs.
Risk Level: Low
Testing: Added a small unit test to ensure that the metadata could be populated and extracted from ClusterInfo.
Docs Changes: envoyproxy/data-plane-api#408
Release Notes: Does this change require release notes?