grpc-json: no buffering at end_stream or non-gRPC response #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <zlizan@google.com>
| @@ -70,6 +72,14 @@ class TranscoderImpl : public Transcoder { | |||
| std::unique_ptr<TranscoderInputStream> response_stream_; | |||
| }; | |||
|
|
|||
| bool isGrpcResponse(const Http::HeaderMap& headers) { | |||
| if (strcmp("200", headers.Status()->value().c_str()) != 0) { | |||
There was a problem hiding this comment.
Please use getResponseStatus here to match similar code elsewhere.
| return false; | ||
| } | ||
| return headers.ContentType() && | ||
| Http::Headers::get().ContentTypeValues.Grpc == headers.ContentType()->value().c_str(); |
There was a problem hiding this comment.
I think this will cause a string temporary to be created. If you invert it won't:
headers.ContentType()->value() == Http::Headers::get().ContentTypeValues.Grpc.c_str()
There was a problem hiding this comment.
Done.
I'm fine either though I don't think it will make a string temporary, as <string> defines:
bool operator== (const string& lhs, const char* rhs);
There was a problem hiding this comment.
Ah, good to know. Thanks for pointing that out.
Signed-off-by: Lizan Zhou <zlizan@google.com>
mattklein123
previously approved these changes
Jan 14, 2018
htuch
reviewed
Jan 14, 2018
| if (Http::Utility::getResponseStatus(headers) != 200) { | ||
| return false; | ||
| } | ||
| return headers.ContentType() && |
There was a problem hiding this comment.
Should this use https://github.com/envoyproxy/envoy/blob/master/source/common/grpc/common.cc#L25? Maybe this util belongs in Grpc::Common as well.
Signed-off-by: Lizan Zhou <zlizan@google.com>
Signed-off-by: Lizan Zhou <zlizan@google.com>
source/common/grpc/common.h
Outdated
| @@ -28,10 +28,17 @@ class Common { | |||
| public: | |||
| /** | |||
| * @param headers the headers to parse. | |||
| * @param bool indicating wether the header is at end_stream. | |||
There was a problem hiding this comment.
? (I think you meant to put this below)
Signed-off-by: Lizan Zhou <zlizan@google.com>
Signed-off-by: Lizan Zhou <zlizan@google.com>
Signed-off-by: Lizan Zhou <zlizan@google.com>
mattklein123
approved these changes
Jan 17, 2018
htuch
approved these changes
Jan 17, 2018
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Improves security with respect to third-party actions. See: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions I also read through the recent commits and updated to the latest release, since it contained a few bugfixes. Risk: Low Testing: CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Improves security with respect to third-party actions. See: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions I also read through the recent commits and updated to the latest release, since it contained a few bugfixes. Risk: Low Testing: CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou zlizan@google.com
Description:
Make gRPC-JSON transcoder not buffering response at end_stream or non-gRPC response.
Risk Level: Low
Testing:
unit test
Docs Changes:
N/A
Release Notes:
N/A
Fixes #2275