Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump rules_pkg -> 0.7.1 #23691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 26, 2022

Fix #23048

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 26, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #23691 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Oct 27, 2022

not sure why this is failing - the actual failure is in the preceding step (which passed):

gnupg: WARNING gpg returned a non-zero error code: 2

which should have failed itself - also not sure how this is related to the change in the PR but it does seem to be reliably failing

(EDIT: not due to this - this was just gpg keyring creation)

@phlax
Copy link
Member Author

phlax commented Oct 28, 2022

running the package verification manually ...

# dscverify --keyring /usr/share/debsign/keyring.gpg /tmp/install/deb/envoy_1.25.0-dev_amd64.bullseye.changes 
/tmp/install/deb/envoy_1.25.0-dev_amd64.bullseye.changes:
      Good signature found
dscverify: no file spec lines in /tmp/install/deb/envoy_1.25.0-dev_amd64.bullseye.changes
Validation FAILED!!

seems like something changed (or maybe was broken) with rules_pkg deb builds

@phlax
Copy link
Member Author

phlax commented Oct 28, 2022

upstream issue here bazelbuild/rules_pkg#632

@wrowe
Copy link
Contributor

wrowe commented Oct 28, 2022

Upstream issue seems stalled in the short-term until Dec

/wait

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 27, 2022
@phlax phlax added no-stalebot and removed stale stalebot believes this issue/PR has not been touched recently labels Nov 28, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 28, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 4, 2023
@phlax phlax reopened this Jan 4, 2023
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently no-stalebot labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies no stalebot Disables stalebot from closing an issue waiting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newer release available rules_pkg: 0.7.1 (current: 0.7.0)
2 participants