Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file size to DirectoryEntry #24176

Merged
merged 20 commits into from
Dec 7, 2022
Merged

Add file size to DirectoryEntry #24176

merged 20 commits into from
Dec 7, 2022

Commits on Nov 23, 2022

  1. Add file size to DirectoryEntry 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    60306a9 View commit details
    Browse the repository at this point in the history

  2. Add test to validate size 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    2a19b95 View commit details
    Browse the repository at this point in the history

  3. Fix tests 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    19c8a58 View commit details
    Browse the repository at this point in the history

  4. Fix mistaken const 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    9cc86ca View commit details
    Browse the repository at this point in the history

  5. makeEntry test needs to be filesystem-independent 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    331c5af View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Drop unused temps, clarify the final FileType case. 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    47323f2 View commit details
    Browse the repository at this point in the history

  2. TODO for not throwing exception. 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    78d3c79 View commit details
    Browse the repository at this point in the history

  3. Assert success of test file operations 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2a6b3ab View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Fix operator==, improve test output, simplify flow 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    6037bb9 View commit details
    Browse the repository at this point in the history

  2. ASSERT->EXPECT 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    99a7632 View commit details
    Browse the repository at this point in the history

  3. Windows style large integers without byte shuffling 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    2ce171d View commit details
    Browse the repository at this point in the history

  4. *Unsigned* large integer 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    2eecbfc View commit details
    Browse the repository at this point in the history

  5. Turn off linter for PrintTo 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4e840cd View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Allow indeterminate size for non-regular files; Windows has size-0 sy… 

    …mlinks, Linux has actual file size symlinks.

Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    5acaaf7 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Merge remote-tracking branch 'upstream/main' into stat 

    (Maybe fix unrelated test failures.)

Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    b582141 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Use absl::nullopt to indicate size unknown 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ae4ae1f View commit details
    Browse the repository at this point in the history

  2. Correct test comment that still said 0 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    0257b05 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Only get size when used, and fix grouping, for Win32 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    de66291 View commit details
    Browse the repository at this point in the history

  2. Add testing of DirectoryEntry == operator 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    f11bd48 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into stat 

    Signed-off-by: Raven Black <ravenblack@dropbox.com>
    @ravenblackx
    ravenblackx committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6c3d3b4 View commit details
    Browse the repository at this point in the history