Reduce Route memory utilization by avoiding RuntimeData instances when not needed #24327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n not needed Currently an instance of RuntimeData is created in each route, even if no runtime fractions are configured. This PR switches the instance to unique_ptr and only creates RuntimeData objects when actually configured. This is a step towards more memory efficient config data structures. Issue envoyproxy#24154. Signed-off-by: Yury Kats <ykats@google.com>
Signed-off-by: Yury Kats <ykats@google.com>
|
/assign @adisuissa @zuercher |
|
@zuercher please take a look, thanks! |
zuercher
approved these changes
Dec 7, 2022
|
/retest |
|
Retrying Azure Pipelines: |
|
@yurykats i kicked the pipeline manually - not sure if |
|
/retest |
|
Retrying Azure Pipelines: |
jpsim
added a commit
that referenced
this pull request
Dec 8, 2022
…-cpp-to-latest-version * origin/main: (23 commits) Reduce Route memory utilization by avoiding RuntimeData instances when not needed (#24327) build: fix compile error for mac (#24429) postgres: support for upstream SSL (#23990) iOS: split `EnvoyEngine.h` into multiple header files (#24397) mobile: check for pending exceptions after JNI call (#24361) Remove uneccessary `this->` from mobile engine builder (#24389) Add setRequestDecoder to ResponseEncoder interface (#24368) downstream: refactoring code to remove listener hard deps (#24394) lb api: moving load balancing policy specific configuration to extension configuration (#23967) ci: Skip docker/examples verification for docs or mobile only changes (#24417) ci: run mobile GitHub Actions on every PR (#24407) mobile: remove `bump_lyft_support_rotation.sh` script (#24404) Add file size to DirectoryEntry (#24176) bazel: update to 6.0.0rc4 (#24235) bazel: update rules_rust (#24409) Ecds config dump recommit (#24384) bazel: add another config_setting incompatible flag (#24270) listeners: moving listeners to extension directory (#24248) mobile: build Swift with whole module optimization (#24396) ci: update `actions/setup-java` from v1 to v3.8 (#24393) ... Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce Route memory utilization by avoiding RuntimeData instances when not needed
Currently an instance of RuntimeData (wrapped in optional) is created in each route, even if no runtime fractions are configured. This PR switches the instance to unique_ptr and only creates RuntimeData objects when actually configured.
This is a step towards more memory efficient config data structures. Issue #24154.
Signed-off-by: Yury Kats ykats@google.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]