Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving more files into the listener manager directory. #24419

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Moving more files into the listener manager directory. #24419

merged 1 commit into from
Dec 8, 2022

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Dec 7, 2022 •
edited
Loading

plus follow-ups from #24394

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:

@alyssawilk
Movigg more files into the listener manager directory.
c4a3ff8 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24419 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk changed the title Movigg more files into the listener manager directory. Moving more files into the listener manager directory. Dec 7, 2022
@alyssawilk alyssawilk marked this pull request as ready for review December 7, 2022 19:36
@alyssawilk
Copy link
Contributor Author

(clang tidy error is legacy error)

snowp
snowp approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love the extra comments

@alyssawilk alyssawilk merged commit a6b767e into envoyproxy:main Dec 8, 2022
@alyssawilk alyssawilk deleted the followup_api_listener branch April 5, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowp snowp snowp approved these changes

Assignees

@snowp snowp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssawilk @snowp