kafka: add upstream-kafka-consumer #24431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkotwasinski
force-pushed
the
kafka-contrib-2
branch
from
b96504e
to
7e6c1da
Compare
adamkotwasinski
changed the title
adamkotwasinski
force-pushed
the
kafka-contrib-2
branch
3 times, most recently
from
166c42c
to
ae460fd
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-contrib-2
branch
5 times, most recently
from
76e8676
to
3d6034f
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-contrib-2
branch
2 times, most recently
from
d28f3b6
to
e133335
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-contrib-2
branch
from
e133335
to
6331d43
Compare
adamkotwasinski
changed the title
|
/assign @mattklein123 |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-contrib-2
branch
from
78c5769
to
74fef0d
Compare
mattklein123
approved these changes
Dec 11, 2022
|
Thank you! |
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 1, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 1, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Jun 2, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Jun 2, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: add upstream-kafka-consumer
Additional Description: Add the upstream Kafka consumer (analogous to already existing upstream Kafka producer). As it is performing blocking operations (
consume) it needs to run in a dedicated worker thread to consume the records. Compared to the producer it is a bit more complex, as it does not always need to consume the records - first it needs to check whether there is anyone interested in these topics (== if there are unfinishedFetchrequests received by the mesh filter). Part of #24372.Risk Level: Low
Testing: unit tests, integration tests with full stack
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A