-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deflake directory iterator for windows #24469
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo comment request.
Could merge w/o that of course to ease the flakes.
@@ -50,7 +50,8 @@ DirectoryEntry DirectoryIteratorImpl::makeEntry(const WIN32_FIND_DATA& find_data | |||
return {std::string(find_data.cFileName), FileType::Other, absl::nullopt}; | |||
} else if (find_data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) { | |||
return {std::string(find_data.cFileName), FileType::Directory, absl::nullopt}; | |||
} else if (find_data.dwReserved0 & IO_REPARSE_TAG_SYMLINK) { | |||
} else if ((find_data.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the link from the description into the source code here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Sync past mobile_docs CI failure. Signed-off-by: Raven Black <ravenblack@dropbox.com>
Commit Message: Deflake directory iterator for windows
Additional Description: #24176 made windows CI flaky - I mistakenly used a flag without checking if the prerequisite other flag that makes that flag meaningful was present. This fixes that.
Relevant documentation:
Risk Level: Negative.
Testing: CI should stop being flaky. Cannot test directly, no Windows.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: It's Windows-only.