kafka: inbound record distributor/store #24518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-distributor
branch
2 times, most recently
from
98e927a
to
1f1c5cd
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-distributor
branch
from
1f1c5cd
to
3407902
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-distributor
branch
from
3407902
to
84f46e5
Compare
…nds processing) Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-distributor
branch
from
6662c67
to
2d4ead6
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
|
/assign @mattklein123 |
mattklein123
approved these changes
Dec 16, 2022
|
Thank you! |
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: inbound record distributor/store
Additional Description:
RecordDistributorobject that's responsible for routing records to callbacks (downstream Fetch requests) that are waiting for these requests. Needs to be thread-safe just like it's owner SHM, as it's going to be accessed by multiple threads (from the callback side: multiple filters -> multiple worker threads, from the message side: kafka consumer's worker thread that pushes the messages in). Part of #24372Risk Level: Low
Testing: unit tests, integration test with a full stack
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A