Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: fetch record converter #25300

Merged
merged 10 commits into from
Feb 10, 2023
Merged

Conversation

adamkotwasinski
Copy link
Contributor

Commit Message: kafka: fetch record converter
Additional Description: Add a way to convert (at least somewhat) the received records (from upstream Kafka clusters) to record bytes we are going to send to downstream clients. Part of #24372
Risk Level: Low
Testing: unit tests, integration tests with full stack
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #25300 was opened by adamkotwasinski.

see: more, trace.

…a downstream)

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@adamkotwasinski
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #25300 (comment) was created by @adamkotwasinski.

see: more, trace.

@adamkotwasinski adamkotwasinski marked this pull request as ready for review February 9, 2023 04:32
@adamkotwasinski
Copy link
Contributor Author

/assign @mattklein123

@mattklein123 mattklein123 merged commit c6d6b3d into envoyproxy:main Feb 10, 2023
@adamkotwasinski
Copy link
Contributor Author

Thank you!

@adamkotwasinski adamkotwasinski deleted the kafka-frc branch February 10, 2023 18:00
phlax pushed a commit to phlax/envoy that referenced this pull request Aug 22, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Aug 25, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants