Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use tmpfs directories for self-hosted agents #26159

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Mar 19, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax changed the title ci: Use tmpfs directories for self-hosted agents [WIP] ci: Use tmpfs directories for self-hosted agents Mar 19, 2023
@phlax phlax marked this pull request as draft March 19, 2023 08:10
@phlax
Copy link
Member Author

phlax commented Mar 19, 2023

requires #26156 to prevent using tmpfs filling up on the ARM release run

@phlax phlax force-pushed the ci-tmpfs-dirs branch 3 times, most recently from dc9ad0c to 5f1775e Compare March 20, 2023 06:50
@phlax
Copy link
Member Author

phlax commented Mar 20, 2023

This would break on main as it doesnt use cached test results and so downloads too much to use a tmpfs mount

@phlax
Copy link
Member Author

phlax commented Mar 20, 2023

this also breaks when there are changes

ill remove the /tmp directory - the rest should be good

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] ci: Use tmpfs directories for self-hosted agents ci: Use tmpfs directories for self-hosted agents Mar 21, 2023
@phlax phlax marked this pull request as ready for review March 21, 2023 08:33
@phlax
Copy link
Member Author

phlax commented Mar 21, 2023

this has been tested without test caching (ie same as postsubmit)

.azure-pipelines/bazel.yml Outdated Show resolved Hide resolved
@@ -403,6 +403,7 @@ stages:
parameters:
managedAgent: false
ciTarget: bazel.release
bazelBuildExtraOptions: "--sandbox_base=/tmp/sandbox_base"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto here - I'm always baffled when we add something in one place and I can't tell the effect
I know we largely haven't commented any of this in the past but I'd love to do more if you're game?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is added because the x64 build job now uses a self-hosted agent and so has a lot more memory and can do this - it brings it into line with other jobs

for this the better solution is probably that this is added elsewhere depending on the capability etc (there are other moving parts here)

atm im more focused on regorganizing things that doccing them - mostly i want to get a clearer separation of responsibilities in CI - its a bit confused/confusing atm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I just think it'd be helpful t have more explanation of what these do inline.

Signed-off-by: Ryan Northey <ryan@synca.io>
@alyssawilk alyssawilk self-assigned this Mar 22, 2023
@phlax phlax merged commit 6da9544 into envoyproxy:main Mar 22, 2023
phlax added a commit to phlax/envoy that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants