-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use tmpfs directories for self-hosted agents #26159
Conversation
requires #26156 to prevent using tmpfs filling up on the ARM release run |
dc9ad0c
to
5f1775e
Compare
This would break on |
this also breaks when there are changes ill remove the |
Signed-off-by: Ryan Northey <ryan@synca.io>
this has been tested without test caching (ie same as postsubmit) |
@@ -403,6 +403,7 @@ stages: | |||
parameters: | |||
managedAgent: false | |||
ciTarget: bazel.release | |||
bazelBuildExtraOptions: "--sandbox_base=/tmp/sandbox_base" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto here - I'm always baffled when we add something in one place and I can't tell the effect
I know we largely haven't commented any of this in the past but I'd love to do more if you're game?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is added because the x64 build job now uses a self-hosted agent and so has a lot more memory and can do this - it brings it into line with other jobs
for this the better solution is probably that this is added elsewhere depending on the capability etc (there are other moving parts here)
atm im more focused on regorganizing things that doccing them - mostly i want to get a clearer separation of responsibilities in CI - its a bit confused/confusing atm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure I just think it'd be helpful t have more explanation of what these do inline.
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]