Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increasing range for non-determinstic check #26263

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

alyssawilk
Copy link
Contributor

https://dev.azure.com/cncf/envoy/_build/results?buildId=131803&view=logs&j=8bf29878-a4cc-50f7-4e84-2255e6fd4065&t=10423dec-52d0-5521-c797-f153bdaa8e53&l=861

[ RUN ] HttpConnectionManagerConfigTest.OverallSampling
test/extensions/filters/network/http_connection_manager/config_test.cc:676: Failure
Expected: (900) <= (sampled_count), actual: 900 vs 898
Stack trace:
0x564605d3ccc3: Envoy::Extensions::NetworkFilters::HttpConnectionManager::(anonymous namespace)::HttpConnectionManagerConfigTest_OverallSampling_Test::TestBody()
0x56460840c924: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
0x5646084079f7: testing::internal::HandleExceptionsInMethodIfSupported<>()
0x5646083ee9c2: testing::Test::Run()
0x5646083ef399: testing::TestInfo::Run()
... Google Test internal frames ...

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alyssawilk

@alyssawilk alyssawilk merged commit fad2a2c into envoyproxy:main Mar 24, 2023
ashishb-solo pushed a commit to ashishb-solo/envoy that referenced this pull request Mar 24, 2023
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Ashish Banerjee <ashish.banerjee@solo.io>
@alyssawilk alyssawilk deleted the hcm_flake branch March 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants