Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: moving exceptions to higher level of code #27288

Merged
merged 1 commit into from
May 11, 2023
Merged

cluster: moving exceptions to higher level of code #27288

merged 1 commit into from
May 11, 2023

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented May 9, 2023 •
edited
Loading

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
part of envoyproxy/envoy-mobile#176

@alyssawilk
cluster: moving exceptions to higher level of code
83423b7 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #27288 was opened by alyssawilk.

see: more, trace.

@alyssawilk
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #27288 (comment) was created by @alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review May 10, 2023 15:41
@RyanTheOptimist
Copy link
Contributor

/assign @mattklein123

@alyssawilk alyssawilk merged commit d152699 into envoyproxy:main May 11, 2023
75 checks passed
wbpcode pushed a commit to wbpcode/envoy that referenced this pull request May 16, 2023
@alyssawilk @wbpcode
cluster: moving exceptions to higher level of code (envoyproxy#27288)
eac8057 
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
part of envoyproxy/envoy-mobile#176

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
@alyssawilk @reskin89
cluster: moving exceptions to higher level of code (envoyproxy#27288)
e4801ba 
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
part of envoyproxy/envoy-mobile#176

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
@alyssawilk alyssawilk deleted the cluster_exception branch March 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssawilk @RyanTheOptimist @mattklein123