test: fix flaky test DownstreamProtocolIntegrationTest.HandleDownstreamSocketFail #27546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
RyanTheOptimist
approved these changes
May 23, 2023
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 16, 2023
…amSocketFail (envoyproxy#27546) The test manually introduces EBADF error on the connection between Envoy and the test client. However, the IoHandleMatcher doesn't distinguish UDP socket from TCP. If the upstream HTTP/3 connection gets the same port number as downstream TCP connection, the EBADF error will be applied to the wrong connection. Enforce IoHandleMatcher to match socket type. Risk Level: low, test only Testing: existing tests Docs Changes: N/A Release Notes: N/A Partially Fix envoyproxy#27490 Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 16, 2023
…amSocketFail (envoyproxy#27546) The test manually introduces EBADF error on the connection between Envoy and the test client. However, the IoHandleMatcher doesn't distinguish UDP socket from TCP. If the upstream HTTP/3 connection gets the same port number as downstream TCP connection, the EBADF error will be applied to the wrong connection. Enforce IoHandleMatcher to match socket type. Risk Level: low, test only Testing: existing tests Docs Changes: N/A Release Notes: N/A Partially Fix envoyproxy#27490 Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: danzh <danzh2010@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Jun 20, 2023
…amSocketFail (#27546) The test manually introduces EBADF error on the connection between Envoy and the test client. However, the IoHandleMatcher doesn't distinguish UDP socket from TCP. If the upstream HTTP/3 connection gets the same port number as downstream TCP connection, the EBADF error will be applied to the wrong connection. Enforce IoHandleMatcher to match socket type. Risk Level: low, test only Testing: existing tests Docs Changes: N/A Release Notes: N/A Partially Fix #27490 Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
…amSocketFail (envoyproxy#27546) The test manually introduces EBADF error on the connection between Envoy and the test client. However, the IoHandleMatcher doesn't distinguish UDP socket from TCP. If the upstream HTTP/3 connection gets the same port number as downstream TCP connection, the EBADF error will be applied to the wrong connection. Enforce IoHandleMatcher to match socket type. Risk Level: low, test only Testing: existing tests Docs Changes: N/A Release Notes: N/A Partially Fix envoyproxy#27490 Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test manually introduces EBADF error on the connection between Envoy and the test client. However, the IoHandleMatcher doesn't distinguish UDP socket from TCP. If the upstream HTTP/3 connection gets the same port number as downstream TCP connection, the EBADF error will be applied to the wrong connection.
Enforce IoHandleMatcher to match socket type.
Risk Level: low, test only
Testing: existing tests
Docs Changes: N/A
Release Notes: N/A
Partially Fix #27490