Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.25] Backport stack #28122

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 23, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax requested a review from snowp as a code owner June 23, 2023 16:12
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 23, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #28122 was opened by phlax.

see: more, trace.

kyessenov and others added 4 commits June 23, 2023 17:13
* original_dst: fix timer lifetime

Signed-off-by: Kuat Yessenov <kuat@google.com>

Signed-off-by: Kuat <kyessenov@users.noreply.github.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
…roxy#28000)

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Jun 23, 2023

cc @kyessenov

@phlax
Copy link
Member Author

phlax commented Jun 23, 2023

/wait for original_dst fix changelog

wbpcode
wbpcode previously approved these changes Jun 25, 2023
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Signed-off-by: Kuat Yessenov <kuat@google.com>

Signed-off-by: Kuat <kyessenov@users.noreply.github.com>
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax merged commit e3c892c into envoyproxy:release/v1.25 Jun 26, 2023
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants