mobile/ci: Fix iOS build failures #31756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredyw
changed the title
|
/retest |
The error: ``` ERROR: /Users/runner/work/envoy/envoy/mobile/WORKSPACE:98:18: fetching android_sdk_repository rule //external:androidsdk: Android SDK api level 30 was requested but it is not installed in the Android SDK at /Users/runner/Library/Android/sdk. The api levels found were [34, 33, 32, 31]. Please choose an available api level or install api level 30 from the Android SDK Manager. ``` This PR is a workaround to install Android SDK 30 even though it's not used for building iOS apps, that's because mobile/WORKSPACE expects the Android SDK 30 to be available and GitHub Runner image no longer includes Android SDK 30. See actions/runner-images#8952. Passing `--android` in the `./ci/mac_ci_setup.sh` will install the Android SDK 30. Signed-off-by: Fredy Wijaya <fredyw@google.com>
fredyw
force-pushed
the
mobile_ios_build_fix
branch
from
4b46251
to
cb433bb
Compare
|
/assign @abeyad |
abeyad
approved these changes
Jan 11, 2024
keith
added a commit
that referenced
this pull request
Feb 23, 2024
This reverts commit f37ef3f. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
phlax
pushed a commit
that referenced
this pull request
Feb 23, 2024
ohadvano
pushed a commit
to ohadvano/envoy
that referenced
this pull request
Feb 25, 2024
…roxy#32558) * Revert "mobile/ci: Fix iOS build failures (envoyproxy#31756)" This reverts commit f37ef3f. and removes unsed code path Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error:
This PR is a workaround to install Android SDK 30 even though it's not used for building iOS apps, that's because
mobile/WORKSPACEexpects the Android SDK 30 to be available and GitHub Runner image no longer includes Android SDK 30. See actions/runner-images#8952. Passing--androidin the./ci/mac_ci_setup.shwill install the Android SDK 30.Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a