-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: keep trailers
TE header instead of removing it
#32255
Merged
RyanTheOptimist
merged 23 commits into
envoyproxy:main
from
quantumsheep:set-te-to-trailers
Feb 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2611451
http: set TE header to `trailers` instead of removing it
quantumsheep cfe8dd4
http: set TE header to `trailers` instead of removing it only in grpc
quantumsheep afc5512
allow "trailers"
quantumsheep 6e96ea4
fix TE header get
quantumsheep 5afbede
handle multiple TE values
quantumsheep 7f34b49
add typing
quantumsheep c19ebc3
move logic inside a dedicated function
quantumsheep fb94a2e
add unit tests
quantumsheep ae3dcbe
simplify search
quantumsheep 1bc9bb6
remove trailers weight from tests
quantumsheep a62aa02
update changelog
quantumsheep 0091898
default reloadable value is true
quantumsheep e0c7156
add test for `sanitize_te` reloadable feature
quantumsheep a330a6b
fix reloadable feature guard
quantumsheep da01b3a
simplify and add comments
quantumsheep 8eebaef
naming
quantumsheep ad06416
explicit typing
quantumsheep 3c9d444
is_trailer naming
quantumsheep d8d5c19
improve explanation
quantumsheep 143ecbc
use `absl::string_view` instead of `std::string`
quantumsheep 80fe87d
format
quantumsheep 785642d
double backticks
quantumsheep 71613ec
fix test name
quantumsheep File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct either. TE may not have been "trailers" to begin with. Maybe check to see if there's a trailers token and if so replace any non'trailers string with trailers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTP/2 and 3 only supports
trailers
TE headers in theory. I added a condition to do this only if the outgoing request is in gRPC, wdyt?