Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dfp: reverting 31433 #32743

Merged
merged 1 commit into from
Mar 7, 2024
Merged

dfp: reverting 31433 #32743

merged 1 commit into from
Mar 7, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Mar 6, 2024 •
edited

reintroduces #30999 :-/

@alyssawilk
dfp: reverting 31433
049ca6e 
Signed-off-by: Alyssa Wilk <alyssar@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32743 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review March 6, 2024 17:41
@alyssawilk alyssawilk enabled auto-merge (squash) March 6, 2024 17:41
@alyssawilk alyssawilk merged commit 8ac6d0c into envoyproxy:main Mar 7, 2024
54 checks passed
@alyssawilk
Copy link
Contributor Author

cc @yanjunxiang-google

mattjo added a commit to mattjo/envoy that referenced this pull request Mar 7, 2024
@mattjo
Merge remote-tracking branch 'origin' into sub_check
c906f33 
* origin:
  mobile: Clean up Java and Kotlin code (envoyproxy#32773)
  [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754)
  oauth2: support disabling redirects for AJAX requests (envoyproxy#32655)
  http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751)
  envoy: reverting unnecessary exception E-M macros (envoyproxy#32745)
  dfp: reverting 31433 (envoyproxy#32743)
  opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681)
  mobile: Java code cleanup (envoyproxy#32747)
  mobile: fix quic_test_server_test (envoyproxy#32755)
  Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanTheOptimist RyanTheOptimist RyanTheOptimist approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

Assignees

@RyanTheOptimist RyanTheOptimist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssawilk @RyanTheOptimist