Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false #32751

Merged
merged 3 commits into from
Mar 7, 2024
Merged

http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false #32751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a06f4eb
Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false
RyanTheOptimist Mar 6, 2024
773357a
changelog
RyanTheOptimist Mar 6, 2024
4af7d6d
TODO
RyanTheOptimist Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelogs/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ behavior_changes:
The runtime flag ``envoy.reloadable_features.enable_include_histograms`` is now enabled by default.
This causes the ``includeHistogram()`` method on ``Stats::SinkPredicates`` to filter histograms to
be flushed to stat sinks.
- area: http2
change: |
Changes the default value of ``envoy.reloadable_features.http2_use_oghttp2`` to ``false``. This changes the codec used for HTTP/2
requests and responses. A number of users have reported issues with oghttp2 including issue 32611 and issue 32401 This behavior
can be reverted by setting the feature to ``true``.
- area: eds
change: |
Enabling caching caching of EDS assignments when used with ADS by default (introduced in Envoy v1.28).
Expand Down
5 changes: 3 additions & 2 deletions source/common/runtime/runtime_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_connection_close_header_in_redirec
RUNTIME_GUARD(envoy_reloadable_features_http1_use_balsa_parser);
RUNTIME_GUARD(envoy_reloadable_features_http2_decode_metadata_with_quiche);
RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header);
// Ignore the automated "remove this flag" issue: we should keep this for 1 year.
RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
RUNTIME_GUARD(envoy_reloadable_features_http2_validate_authority_with_quiche);
RUNTIME_GUARD(envoy_reloadable_features_http_allow_partial_urls_in_referer);
RUNTIME_GUARD(envoy_reloadable_features_http_filter_avoid_reentrant_local_reply);
Expand Down Expand Up @@ -110,6 +108,9 @@ RUNTIME_GUARD(envoy_restart_features_use_eds_cache_for_ads);

// Begin false flags. Most of them should come with a TODO to flip true.

// TODO(birenroy) Flip this to true after resolving issues.
// Ignore the automated "remove this flag" issue: we should keep this for 1 year.
FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
// Execution context is optional and must be enabled explicitly.
// See https://github.com/envoyproxy/envoy/issues/32012.
FALSE_RUNTIME_GUARD(envoy_restart_features_enable_execution_context);
Expand Down