Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mobile] Increase stream response buffer watermark size to 2MB #32754

Merged
merged 12 commits into from
Mar 7, 2024
6 changes: 3 additions & 3 deletions mobile/library/common/http/client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ void Client::DirectStreamCallbacks::encodeData(Buffer::Instance& data, bool end_
response_data_ = std::make_unique<Buffer::WatermarkBuffer>(
[this]() -> void { onBufferedDataDrained(); }, [this]() -> void { onHasBufferedData(); },
[]() -> void {});
// Default to 1M per stream. This is fairly arbitrary and will result in
// Default to 2M per stream. This is fairly arbitrary and will result in
// Envoy buffering up to 1M + flow-control-window for HTTP/2 and HTTP/3,
// and having local data of 1M + kernel-buffer-limit for HTTP/1.1
response_data_->setWatermarks(1000000);
// and having local data of 2M + kernel-buffer-limit for HTTP/1.1
response_data_->setWatermarks(2 * 1024 * 1024);
}

// Send data if in default flow control mode, or if resumeData has been called in explicit
Expand Down