Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.29] http2: Switch the value of envoy.reloadable_features.http2_use_oghttp… #32766

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Mar 7, 2024

…2 to false (#32751)

http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including #32611 and #32401 so reverting this flag seems wise.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…2 to false (envoyproxy#32751)

http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false
A number of users have reported issues with oghttp2 including envoyproxy#32611 and envoyproxy#32401
so reverting this flag seems wise.

Signed-off-by: Ryan Hamilton <rch@google.com>
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #32766 was opened by phlax.

see: more, trace.

@phlax phlax added this to the 1.29.2 milestone Mar 7, 2024
@phlax phlax enabled auto-merge (rebase) March 7, 2024 11:58
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax merged commit 57a0256 into envoyproxy:release/v1.29 Mar 7, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants