tests: text and path glob path matching #33104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jaellio, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
whitneygriffith
approved these changes
Mar 25, 2024
yanavlasov
previously approved these changes
Mar 26, 2024
|
Please merge the main branch to fix CI breakage. /wait |
jaellio
force-pushed
the
jaellio/testpatternmatching
branch
from
97f8cc7
to
8a016a2
Compare
@yanavlasov Updated! |
|
Please merge past 7fdde72 Seems like you did not pick up all the necessary updates. /wait |
path pattern matching. Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
jaellio
force-pushed
the
jaellio/testpatternmatching
branch
from
bd9dd57
to
6333971
Compare
Gotcha, my bad! Updated! |
yanavlasov
approved these changes
Mar 28, 2024
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
Adds additional test cases for path and text glob path pattern matching. --------- Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Adds additional test cases for path and text glob path pattern matching.
Additional Description: Specifically verifies that
=**or**must be the last operator in the path pattern match.Risk Level: Low
Testing: Ran new tests locally.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: