Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Use suffix _ for struct member variables #33278

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Apr 2, 2024

This PR updates the code to use suffix _ for struct member variables as per Envoy Code Style.

Risk Level: low (rename only)
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33278 was opened by fredyw.

see: more, trace.

Signed-off-by: Fredy Wijaya <fredyw@google.com>
@fredyw fredyw force-pushed the struct_member_data_naming branch from cae055c to e13910b Compare April 2, 2024 21:31
@fredyw fredyw marked this pull request as ready for review April 2, 2024 22:19
@fredyw
Copy link
Member Author

fredyw commented Apr 2, 2024

/assign @abeyad

Signed-off-by: Fredy Wijaya <fredyw@google.com>
@fredyw fredyw enabled auto-merge (squash) April 2, 2024 22:29
Copy link
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL the Envoy style guide differs from the Google style guide in struct variables also having trailing underscores! https://github.com/envoyproxy/envoy/blob/main/STYLE.md#deviations-from-google-c-style-guidelines

@fredyw fredyw merged commit 06ea913 into envoyproxy:main Apr 3, 2024
35 checks passed
@fredyw
Copy link
Member Author

fredyw commented Apr 3, 2024

TIL the Envoy style guide differs from the Google style guide in struct variables also having trailing underscores! https://github.com/envoyproxy/envoy/blob/main/STYLE.md#deviations-from-google-c-style-guidelines

Yup, this caught me off guard, too. I thought it was the same as the C++ Google style :)

@fredyw fredyw deleted the struct_member_data_naming branch April 3, 2024 00:08
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
This PR updates the code to use suffix _ for struct member variables as per Envoy Code Style.

Risk Level: low (rename only)
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <fredyw@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants