load shed: add load shed check in downstream decoder filters #33366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boteng Yao <boteng@google.com>
…sp_callback Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
|
/assign @yanavlasov |
|
/assign @KBaichoo |
botengyao
changed the title
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
…sp_callback Signed-off-by: Boteng Yao <boteng@google.com>
KBaichoo
previously approved these changes
Apr 11, 2024
Signed-off-by: Boteng Yao <boteng@google.com>
yanavlasov
requested changes
Apr 12, 2024
Signed-off-by: Boteng Yao <boteng@google.com>
yanavlasov
approved these changes
Apr 15, 2024
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Apr 18, 2024
…oxy#33366) --------- Signed-off-by: Boteng Yao <boteng@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…oxy#33366) --------- Signed-off-by: Boteng Yao <boteng@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make load shed check available in downstream decoder callbacks by adding one more lsp to filter manager, and added the check in router.
The idea is to make the filters in the filter chain can shed load since we may have a lot of side streams, and creating upstream can also be heavy. Not sure if we want to make it configureable for router with a bool button, not only for the load shed point.
Happy to hear any thoughts.
Commit Message:
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]