router: set upstream host from the conn pool #33790
Open
CI (Envoy) / Mobile/Coverage
skipped
Apr 28, 2024 in 0s
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/33790/main@1d500a7)
1d500a7 
#33790 merge main@81c6142
router: set upstream host from the conn pool
Commit Message: router: set upstream host from the conn pool
Additional Description:The
host()method of connection pool will return a host in current implementation. We can set the host at constructor ofUpstreamRequestand needn't to wait the pool callbacks.Considering a scenario like this, if the request is timeout before any pool callbacks are called, then the upstream host will never be set and we can even cannot know which host is selected for this request from the access log.
Risk Level: mid, core logic change.
Testing: wait.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.
Environment
Request variables
| Key | Value |
|---|---|
| ref | 9c2e502 |
| sha | 1d500a7 |
| pr | 33790 |
| base-sha | 81c6142 |
| actor | @wbpcode |
| message | router: set upstream host from the conn pool... |
| started | 1714271280.097695 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 31 |
| patch | 0 |
| dev | true |
Loading