hcm: fix crash due to config lifetime when loading hcm via ECDS #33805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes envoyproxy#33801 Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
LGTM. Thanks. Please merge main and resolve the conflict, thanks. |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
wbpcode
approved these changes
Apr 26, 2024
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…yproxy#33805) Fixes envoyproxy#33801 Signed-off-by: Greg Greenway <ggreenway@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Fixes a use-after-free of the HCM config if a request is in progress when the config is reloaded via ECDS.
Additional Description:
Risk Level: Low
Testing: manual
Docs Changes:
Release Notes: added
Platform Specific Features:
[Optional Runtime guard:]
Fixes #33801
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]