dlb: add how to use #33818
dlb: add how to use #33818
Conversation
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/33818/docs/index.html The docs are (re-)rendered each time the CI |
|
/retest |
|
/wait on CI |
repokitteh-read-only
bot
added
waiting
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
@adisuissa sorry for mistake :( |
|
still failing format and publishing ci /wait |
Signed-off-by: Loong <loong.dai@intel.com>
|
Force push to fix DCO. |
|
@phlax please help review :) |
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/33818/docs/index.html The docs are (re-)rendered each time the CI |
|
@daixiang0 there are a lot of format issues - see https://storage.googleapis.com/envoy-pr/c0fc41e/docs/configuration/other_features/dlb.html could you resolve these first and then i can review |
|
/wait |
|
@phlax please check the latest, CI is happy. |
|
@daixiang0 please look at the rendered docs - they are obviously not correct |
Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
|
@phlax thanks, now it works. See https://storage.googleapis.com/envoy-pr/dee68e7/docs/configuration/other_features/dlb.html |
Signed-off-by: Loong <loong.dai@intel.com>
There was a problem hiding this comment.
thanks for working on this @daixiang0 - i think as this is config reference for Envoy we dont really want to include nginx or any specific upstream here - just document and highlight what configuration is required to make it work
| Create a config file named `dlb-config.yaml` to make Envoy listen 10000 port as proxy, the upstream server listens 12000 port. | ||
|
|
||
| .. literalinclude:: _include/dlb_example_config.yaml | ||
| :language: yaml |
There was a problem hiding this comment.
could you add linenos, lineno-start and a caption with download link please
to see existing examples you can do something like git grep lineno-start docs/
There was a problem hiding this comment.
lets highlight lines 7-11 - also not sure we need the entire file included as it can be downloaded
when including only a part of the config i tend to include 2 lines before and after
|
@phlax thanks, I have updated all. Also I see two download button, maybe the framework bug: |
There was a problem hiding this comment.
thanks for iterating @daixiang0 - this is close to landing i think
| :linenos: | ||
| :caption: :download:`dlb_example_config.yaml <_include/dlb_example_config.yaml>` | ||
|
|
||
| Run the upstream service: |
There was a problem hiding this comment.
lets remove this - no need to mention nginx - better to be upstream agnostic
| Create a config file named `dlb-config.yaml` to make Envoy listen 10000 port as proxy, the upstream server listens 12000 port. | ||
|
|
||
| .. literalinclude:: _include/dlb_example_config.yaml | ||
| :language: yaml |
There was a problem hiding this comment.
lets highlight lines 7-11 - also not sure we need the entire file included as it can be downloaded
when including only a part of the config i tend to include 2 lines before and after
|
|
||
| $ ./envoy --concurrency 2 -c dlb_example_config.yaml | ||
|
|
||
| Test: |
There was a problem hiding this comment.
not sure we need this section at all - this kinda instruction would be more suited to sandbox/examples - here we are just showing the necessary/minimum configuration to make it work
There was a problem hiding this comment.
For the "upstream" part and "test" part, I put those here since CI do not have DLB device and cannot run this feature, so I do not put those to sandbox/examples.
My goal is to make an complete example to users, if possible, maybe do not do verify, I can move those to examples, which is more suitable.
phlax
removed
the
deps
looks correct to me here https://storage.googleapis.com/envoy-pr/5112fcc/docs/configuration/other_features/dlb.html |
|
@daixiang0 one thing im trying to understand ... with DLB does it load balance between multiple upstream clusters? should the example config have multiple clusters? perhaps i just dont fully understand what it does |
Now Envoy use multi-threads to handle connections, there is only one balance policy called exact balancer. The DLB connection balancer can balance the connections between the threads at local, but not helpful for upstream clusters. |
Add doc about how to use.
Commit Message:
Additional Description:
Risk Level: low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]