New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dlb: upgrade to 8.8 #33834
dlb: upgrade to 8.8 #33834
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
1ef6a25
to
fed50c0
Compare
Now the latest layout is like:
I want to run I can not use I also tried to copy this header file into libdlb dir, but failed to find a way to do it. @phlax is there a way to do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/wait
@phlax @adisuissa sorry that I add some local changes here :( |
I try to move files into one dir by Bazel and fail, so I just move the file by patch. |
Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'll let @phlax have the final say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would have preferred we avoid the patch altogether - but this is definitely better than the previous iteration
lgtm, thanks @daixiang0
Commit Message: Upgrade libdlb to 8.8
Additional Description:
Risk Level: Low
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]