ci/linting: Update envoy.code.check for yamllint
#33849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
force-pushed
the
code-check-yamllint
branch
2 times, most recently
from
7628a53
to
75fabd9
Compare
phlax
requested review from
RyanTheOptimist,
alyssawilk,
abeyad,
fredyw and
mattklein123
as code owners
phlax
force-pushed
the
code-check-yamllint
branch
from
75fabd9
to
e514a2c
Compare
phlax
changed the title
envoy.code.check for yamllintenvoy.code.check for yamllint
phlax
force-pushed
the
code-check-yamllint
branch
2 times, most recently
from
6130c46
to
59cea39
Compare
phlax
changed the title
envoy.code.check for yamllintenvoy.code.check for yamllint
phlax
force-pushed
the
code-check-yamllint
branch
2 times, most recently
from
d568ca2
to
ea842a3
Compare
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/33849/docs/index.html The docs are (re-)rendered each time the CI |
phlax
force-pushed
the
code-check-yamllint
branch
from
ea842a3
to
8d17664
Compare
phlax
changed the title
envoy.code.check for yamllintenvoy.code.check for yamllint
phlax
force-pushed
the
code-check-yamllint
branch
2 times, most recently
from
04b51be
to
3783a4d
Compare
phlax
force-pushed
the
code-check-yamllint
branch
3 times, most recently
from
f14a39b
to
6abd0ca
Compare
phlax
force-pushed
the
code-check-yamllint
branch
2 times, most recently
from
8cc9fcf
to
bb00c68
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
code-check-yamllint
branch
from
bb00c68
to
38d15ea
Compare
phlax
changed the title
envoy.code.check for yamllintenvoy.code.check for yamllint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having some issues with yamllint whereby a lot of files were not being seen - not sure exactly why, possibly upstream bug, maybe a bug in our code.
either way, setting the files to ex/include in .yamllint config file seems to do the trick so this updates to use newer
envoy.code.checkwhich does that and fixes all the hidden yaml failsCommit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]