quic: add listener config option to attach connection debug visitors #34036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a way to configure a quic connection debug visitor factory that will be used to attach a debug visitor to all quic connections on the listener. Adds an interface for this new type of factory. Signed-off-by: Will Lampert <wlampert@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/assign @RyanTheOptimist |
source/common/quic/envoy_quic_connection_debug_visitor_factory_interface.h
Show resolved
Hide resolved
|
/wait |
…extension. Additionally, extend debug visitor constructor to take in a reference to the connection's StreamInfo. Signed-off-by: Will Lampert <wlampert@google.com>
Signed-off-by: Will Lampert <wlampert@google.com>
wlampert
requested review from
alyssawilk,
mattklein123 and
ggreenway
as code owners
Signed-off-by: Will Lampert <wlampert@google.com>
Signed-off-by: Will Lampert <wlampert@google.com>
|
/retest |
|
Looks like an MSAN failure: |
Signed-off-by: Will Lampert <wlampert@google.com>
RyanTheOptimist
approved these changes
May 21, 2024
|
@wbpcode friendly ping for the API review. |
|
This looks like it's causing flakes - Will can you triage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add a way to configure a quic connection debug visitor factory that will be used to attach a debug visitor to all quic connections on the listener. Adds an interface for this new type of factory.
Additional Description:
Risk Level: Low
Testing: Added new tests and modified existing tests in /test/common/quic. Also performed manual testing on a real machine and sent traffic to it using quic_client.
Docs Changes: Update envoy.config.listener.v3.quic_config.proto inline.
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]