[cache filter] Add option to ignore cache-control directives from request #34090
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/34090/main@8f6a60d)
8f6a60d 
#34090 merge main@cdb18db
[cache filter] Add option to ignore cache-control directives from request
Commit Message: [cache filter] Add option to ignore cache-control directives from request
Additional Description: We noticed that, versus nginx cache, upstream was issuing many 304 responses. After some delving into what was happening, I tried commenting out the line that this change makes controllable, and the cache behaved more like our expectations. This PR makes it so we can have that sort of control via an option rather than via a patch.Also addresses #12901 to make configuration more shared rather than initialized per-filter.
Risk Level: Low, it's a WIP filter and the behavior should be the same before and after unless the new option is set.
Testing: Added some.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Environment
Request variables
| Key | Value |
|---|---|
| ref | 160594f |
| sha | 8f6a60d |
| pr | 34090 |
| base-sha | cdb18db |
| actor | @ravenblackx |
| message | [cache filter] Add option to ignore cache-control directives from request... |
| started | 1715359578.898995 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 31 |
| patch | 0 |
| dev | true |