Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external authorization: set the SNI value from server name if it isn't available on the connection/socket #34100

Merged
merged 22 commits into from
May 15, 2024
Merged

external authorization: set the SNI value from server name if it isn't available on the connection/socket #34100

merged 22 commits into from
May 15, 2024

Commits on May 15, 2024

  1. Set the SNI value from the TLS inspector server name if it isn't avai… 

    …lable on the connection/socket.

Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5429cca View commit details
    Browse the repository at this point in the history

  2. Address comments. Adjust setTLSSession() to handle both cases. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    425e5ed View commit details
    Browse the repository at this point in the history

  3. Update setTLSSession() function signature. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    aec9ee1 View commit details
    Browse the repository at this point in the history

  4. Add Envoy namespace. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9602555 View commit details
    Browse the repository at this point in the history

  5. Change setTLSSession() to accept a Envoy::Network::Connection referen… 

    …ce and clang-format.

Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7da868f View commit details
    Browse the repository at this point in the history

  6. Address compilation issues. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f39531b View commit details
    Browse the repository at this point in the history

  7. Adjust existing tests function call counts as the code was changed re… 

    …quiring one less call to connection() and ssl().

Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5fdc9e6 View commit details
    Browse the repository at this point in the history

  8. Add test for the SNI being set by the connections server name when th… 

    …e TLS session SNI isn't set.

Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4ec74e9 View commit details
    Browse the repository at this point in the history

  9. Fix test name. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4cc43cc View commit details
    Browse the repository at this point in the history

  10. Adjust test. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    661ee1a View commit details
    Browse the repository at this point in the history

  11. Fix test. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    16f7b2c View commit details
    Browse the repository at this point in the history

  12. requestedServerName() is correctly called three times for the test. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    53a346d View commit details
    Browse the repository at this point in the history

  13. Bump CI. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    97baa0a View commit details
    Browse the repository at this point in the history

  14. Add test for createHttpCheck() setting the TLS session SNI from the s… 

    …erver name.

Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    23d16bd View commit details
    Browse the repository at this point in the history

  15. Fix test compilation. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6ee761e View commit details
    Browse the repository at this point in the history

  16. Update checks. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    084f8c2 View commit details
    Browse the repository at this point in the history

  17. Create new createHttpCheck() test. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d7e9e73 View commit details
    Browse the repository at this point in the history

  18. Confirm requestedServerName() calls. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3c9552b View commit details
    Browse the repository at this point in the history

  19. Add check for request attributes SNI value being equal to server name… 

    … when the sessions SNI is empty.

Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    27748dc View commit details
    Browse the repository at this point in the history

  20. Fix tests. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e7e9e28 View commit details
    Browse the repository at this point in the history

  21. Remove redundant test. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    28da14d View commit details
    Browse the repository at this point in the history

  22. Update changelogs/current.yaml. 

    Signed-off-by: Marc Barry <4965634+marc-barry@users.noreply.github.com>
    @marc-barry
    marc-barry committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9cd3f27 View commit details
    Browse the repository at this point in the history