-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: migrates DATA frame payloads to the visitor API #34278
Conversation
Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
/assign @diannahu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, clear mapping for the migration! Not sure if the test results are related, but the change LGTM.
Is this a real failure, or a flake?
|
Test passes with |
Signed-off-by: Biren Roy <birenroy@google.com>
Looks like coverage has dropped. Maybe we need to add a tests where the flag is false? Per-extension coverage failed: |
Signed-off-by: Biren Roy <birenroy@google.com>
Head branch was pushed to by a user without write access
Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
/retest |
This slightly simplifies the flow of DATA frame payloads; after this change, the
StreamDataFrameSource
class can be removed.Http2Visitor::OnReadyToSendDataForStream()
is substantially the same implementation asStreamDataFrameSource::SelectPayloadLength()
.Http2Visitor::SendDataFrame()
is substantially the same asStreamDataFrameSource::Send()
.Commit Message: http2: migrates DATA frame payloads to the visitor API
Additional Description:
Risk Level: low
Testing: ran unit and integration tests locally
Docs Changes:
Release Notes: added a note with the runtime feature to disable in case of problems
Runtime guard:
envoy_reloadable_features_http2_use_visitor_for_data